refactor(meshstack/noop): take the runner's endpoint from test_context - #314
Merged
JohannesRudolph merged 1 commit intoSep 7, 2026
Merged
Conversation
Contributor
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — some checks failingBasic module file structure and documentation — applies to 1 modules
Core Structure — Summary
Integration — ✅ all passingmeshstack_integration.tf conventions — applies to 1 modules
Integration — Summary
AWS Backplane — not applicableAWS automation principal conventions (WIF or cross-account StackSet) — applies to 0 modules No applicable modules. Azure Backplane — not applicableAzure UAMI-based automation principal conventions — applies to 0 modules No applicable modules. GCP Backplane — not applicableGCP workload-identity-federation automation principal conventions — applies to 0 modules No applicable modules. STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — ✅ all passingEnd-to-end test coverage — applies to 1 modules
Testing — Summary
|
JohannesRudolph
marked this pull request as ready for review
September 7, 2026 19:32
Base automatically changed from
claude/meshstack-smoke-test-pr49-31ccac
to
main
September 7, 2026 19:45
The last environment fact this module read from a TF_VAR_. The harness now publishes the endpoint in test_context, so the module reads it there like everything else, and the workflow's export can go. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
JohannesRudolph
force-pushed
the
claude/noop-runner-endpoint-from-test-context
branch
from
September 7, 2026 19:56
45c6de5 to
98aab7d
Compare
JohannesRudolph
deleted the
claude/noop-runner-endpoint-from-test-context
branch
September 7, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
meshstack/nooprunner e2e module reads the meshStack endpoint fromTF_VAR_meshstack_endpoint.It is not a secret, so by the
e2e-testskill's rule it belongs intest_context— the harness nowpublishes it there.
This is the last
TF_VAR_*fixture in the module. After it, the harness workflow's export can go andthe runner takes every environment fact from one place.
Depends on
Stacked on #288 (base branch), which is the same change for the GCP project id. Retarget to
mainhappens automatically when #288 merges.
Also needs the harness PR that publishes
test_context.meshstack_endpointto be merged andapplied — until
02_fixturesstate carries the field,test_contextcannot hand it over and thismodule fails at plan time. Cross-linked from that PR.
Verification
tofu validateon the runner module withTF_VAR_test_contextsupplied. The e2e run is verified bya single-module dispatch once the harness field exists.
🤖 Generated with Claude Code